Use trusted publishing for dotnet-release publish job#1453
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1453Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1453" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release workflow to publish NuGet packages using NuGet.org trusted publishing (OIDC) instead of a long-lived API key, aligning the dotnet-release.yml publishing flow with the already-adopted approach in dotnet-main.yml.
Changes:
- Add job-level OIDC permissions to
publish-nuget(id-token: write) for trusted publishing. - Authenticate to NuGet.org via
NuGet/login@v1and use its short-livedNUGET_API_KEYoutput fordotnet nuget push. - Add
--skip-duplicateto avoid failing the job on already-published packages.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dotnet-release.yml | Switch publish-nuget to NuGet trusted publishing (OIDC) and skip duplicate pushes. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
aaronpowell
added
the
skip-nuget-publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #N/A
Update
dotnet-release.ymlsopublish-nugetuses the same trusted publishing flow already indotnet-main.yml: add OIDC job permissions, log in withNuGet/login@v1, switch to the short-lived API key output, and skip duplicate pushes.PR Checklist
Other information
Local validation included YAML parsing and diff checks. Before the first stable publish with trusted publishing, run
dotnet pack -c Release -o ./artifactsto confirm the packages are produced as expected.